[bug-fix] use a default value for device name (#102)

* use a default value for device name * allow configurable names
libdyson-wg · Dec 8, 2023 · 414c6b3 · 414c6b3
1 parent ee89dc9
commit 414c6b3
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/custom_components/dyson_local/config_flow.py b/custom_components/dyson_local/config_flow.py
@@ -310,7 +310,7 @@ async def async_step_host(self, info: Optional[dict] = None):
                     self._device_info.serial,
                     self._device_info.credential,
                     self._device_info.product_type,
-                    self._device_info.name,
+                    info.get(CONF_NAME),
                     info.get(CONF_HOST),
                 )
             except CannotConnect:
@@ -319,15 +319,22 @@ async def async_step_host(self, info: Optional[dict] = None):
                 errors["base"] = "cannot_find"
             else:
                 return self.async_create_entry(
-                    title=self._device_info.name,
+                    title=info.get(CONF_NAME),
                     data=data,
                 )
 
+        # NOTE: Sometimes, the device is not named. In these situations,
+        # default to using the unique serial number as the name.
+        name = self._device_info.name or self._device_info.serial
+
         info = info or {}
         return self.async_show_form(
             step_id="host",
             data_schema=vol.Schema(
-                {vol.Optional(CONF_HOST, default=info.get(CONF_HOST, "")): str}
+                {
+                    vol.Optional(CONF_HOST, default=info.get(CONF_HOST, "")): str,
+                    vol.Optional(CONF_NAME, default=info.get(CONF_NAME, name)): str,
+                }
             ),
             errors=errors,
         )

diff --git a/custom_components/dyson_local/translations/en.json b/custom_components/dyson_local/translations/en.json
@@ -31,7 +31,8 @@
       },
       "host": {
         "data": {
-          "host": "Device IP Address (Optional)"
+          "host": "Device IP Address (Optional)",
+          "name": "Device Name"
         }
       },
       "email": {
@@ -70,4 +71,4 @@
       "already_configured": "Device already configured"
     }
   }
-}
+}