feat: add scripts to tear down and restart resources #31
Conversation
| @@ -105,3 +105,14 @@ delete-traces: | |||
| kubectl delete -k ./cluster-infra/otel-operator/ --ignore-not-found | |||
| kubectl delete -k ./cluster-infra/cert-manager/ --ignore-not-found | |||
| kubectl delete -f https://github.com/flux-iac/tofu-controller/releases/download/v0.15.1/tf-controller.crds.yaml | |||
|
|
|||
| .PHONY: tag-o11y-restart | |||
| tag-o11y-restart: | |||
There was a problem hiding this comment.
nitpick:
I feel like we could simplify this to restart since it doesn't conflict with other targets
There was a problem hiding this comment.
good point, I can just have the target be called restart
| make | ||
|
|
||
| .PHONY: tag-o11y-rollback | ||
| tag-o11y-rollback: |
There was a problem hiding this comment.
It feels like this should be called "destroy" or "delete"
There was a problem hiding this comment.
I can fix this as well and call it rollback
There was a problem hiding this comment.
I am not a fan of this.
quick starts are intended to be used in a local cluster and we can easily just destroy and recreate the cluster. Additionally this script could be destructive if ran with the wrong k8s context and resources match.
The readme changes are good but I dont want the make targets
|
I will remove the make targets and remove the section in the |
This pull request introduces new commands for managing the Kubernetes cluster and updates the documentation to reflect these changes. It also includes a script for rolling back the observability setup.
New commands and scripts:
Makefile: Added newtag-o11y-restartandtag-o11y-rollbackcommands to restart and rollback the observability setup. ([MakefileR108-R118](https://github.com/liatrio/tag-o11y-quick-start-manifests/pull/31/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52R108-R118))scripts/tag-o11y-rollback.sh: Introduced a new script to rollback the observability setup, including stopping port forwarding and deleting resources. ([scripts/tag-o11y-rollback.shR1-R50](https://github.com/liatrio/tag-o11y-quick-start-manifests/pull/31/files#diff-51d8bcedb2ceafd7fd785bf7b5a54cd0d857c72964df1000008dfcba6e9659cbR1-R50))Documentation updates:
README.md: Added instructions for ensuring the Kubernetes cluster is running and updated with commands for restarting and rolling back the observability setup. ([[1]](https://github.com/liatrio/tag-o11y-quick-start-manifests/pull/31/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R33-R47),[[2]](https://github.com/liatrio/tag-o11y-quick-start-manifests/pull/31/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R158-R171))