Skip to content

Commit

Permalink
more debugging
Browse files Browse the repository at this point in the history
  • Loading branch information
jburns24 committed Sep 12, 2023
1 parent 123775d commit ebda59d
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-infra.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,9 @@ jobs:
run: |
aws ecs describe-task-definition --task-definition ${{ env.ecs_task_arn }} --region ${{ env.AWS_REGION }} --output json >> task-definition.json
- name: Check what task-definitions.json looks like
- name: Check what task-definition.json looks like
run: |
cat task-definitions.json
cat task-definition.json
- name: Render Amazon ECS task definition
id: render-web-container
Expand Down
15 changes: 15 additions & 0 deletions terraform/oidc/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,21 @@ data "tls_certificate" "github_thumbprint" {
url = "https://token.actions.githubusercontent.com/.well-known/openid-configuration"
}

## Uncomment this block of code if you are testing this in a personal aws account
## This is a central resource that in my org is not managed via terraform and thus
## including this resouce causes issues.
# resource "aws_iam_openid_connect_provider" "github" {
# url = "https://token.actions.githubusercontent.com"

# # All roles go here.
# # You can find these in the audience of the Github OIDC tokens
# client_id_list = ["sts.amazonaws.com"]

# thumbprint_list = [
# data.tls_certificate.github_thumbprint.certificates[0].sha1_fingerprint
# ]
# }

data "aws_iam_openid_connect_provider" "github" {
url = "https://token.actions.githubusercontent.com"
}
Expand Down

0 comments on commit ebda59d

Please sign in to comment.