Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded email regex and repinned devops-resources to working version #412

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

cfculler
Copy link
Contributor

@cfculler cfculler commented Dec 8, 2023

Closes #411

  • Email validation regex now accepts valid emails that include periods, underscores, and other symbols
  • The api was pinning a bad version for devops-resources, causing compiling to fail. It is now referencing a working version

@@ -4,7 +4,7 @@ go 1.19

require (
github.com/gin-gonic/gin v1.8.1
github.com/liatrio/devops-bootcamp/examples/ch7/devops-resources v0.0.0-20221129190731-63b117bcfecd
github.com/liatrio/devops-bootcamp/examples/ch7/devops-resources v0.0.0-20230921193819-569bb9d9dbdd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love to know what causes this to change. So we can have some confidence that it is not going to happen again 'randomly'

@cfculler cfculler merged commit 26a1d2b into master Dec 8, 2023
3 checks passed
@cfculler cfculler deleted the devops-api-regex branch December 8, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix email validating regex in devops-api
2 participants