Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding github action quiz in addendum #397

Merged
merged 11 commits into from
Oct 12, 2023
Merged

feat: adding github action quiz in addendum #397

merged 11 commits into from
Oct 12, 2023

Conversation

zjorge96
Copy link
Contributor

@zjorge96 zjorge96 commented Oct 4, 2023

No description provided.

@zjorge96 zjorge96 requested review from jburns24 and densellp October 6, 2023 20:35
jburns24
jburns24 requested changes Oct 7, 2023
View reviewed changes
Copy link
Collaborator

@jburns24 jburns24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the importing of the quiz hinged on an id matching a filename let's be defensive. Otherwise :shipit:

index.html Show resolved Hide resolved
@zjorge96 zjorge96 requested a review from jburns24 October 11, 2023 15:54
@zjorge96 zjorge96 merged commit a7515b4 into master Oct 12, 2023
@zjorge96 zjorge96 deleted the gh-certs-quizzes branch October 12, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jburns24 jburns24 jburns24 approved these changes

@densellp densellp Awaiting requested review from densellp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zjorge96 @jburns24 @nsshaddox