Fix for issue #416 #417
Merged
Fix for issue #416 #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgblgblgb
reviewed
Sep 25, 2024
lgblgblgb
reviewed
Sep 25, 2024
|
@RetroCogs Oh, sorry, almost forgot to say: thanks for the PR :D Hopefully you're not mad because of my complains. If it's too much work for you now, I can arrange to accept your changes and I then modify things, just I thought you may want to do the thing yourself. |
|
Updates based on suggestions committed, thanks for the feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue #416, it extends reading all 10 bits of ChrCount and modifies the one place that it's written to.