-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify NetworkChannel interface #147
Conversation
Benchmark results after merging this PR: Benchmark resultsPerformance:PingPongUc: PingPongC: ReactionLatencyUc: ReactionLatencyC: Memory usage:PingPongUc: PingPongC: ReactionLatencyUc: ReactionLatencyC: |
3a6aac2
to
96e37a1
Compare
94c04e4
to
878a945
Compare
opts = (opts & (~O_NONBLOCK)); | ||
} else { | ||
opts = (opts | O_NONBLOCK); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not needed anymore since we can just always block inside of the TcpIpChannel now. It also makes handling the state more easy. The runtime is not blocked by it anymore.
* Migrate runtime and coap channel * Remove complicated LF_RETURN_TYPES from TcpIpChannel * Fix examples and add ctor asserts * Remove network_channel_state_changed callback * Implement naming convention
…ng/reactor-uc into simplify-network-channel-interface
…ng/reactor-uc into simplify-network-channel-interface
…ng/reactor-uc into simplify-network-channel-interface
This branch diverged too much from the one it depended on. Rebasing proofed difficult so I will reopen a new branch with the changes |
WIP: I only migrated the runtime and CoapUdpIpChannel for now.
Depends on: #143