Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify NetworkChannel interface #147

Closed
wants to merge 34 commits into from

Conversation

LasseRosenow
Copy link
Collaborator

WIP: I only migrated the runtime and CoapUdpIpChannel for now.

Depends on: #143

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Benchmark results after merging this PR:

Benchmark results

Performance:

PingPongUc:
Best Time: 137.773 msec
Worst Time: 153.049 msec
Median Time: 140.430 msec

PingPongC:
Best Time: 169.774 msec
Worst Time: 173.405 msec
Median Time: 169.768 msec

ReactionLatencyUc:
Best latency: 19955 nsec
Median latency: 59731 nsec
Worst latency: 182062 nsec

ReactionLatencyC:
Best latency: 19586 nsec
Median latency: 60002 nsec
Worst latency: 166962 nsec

Memory usage:

PingPongUc:
text data bss dec hex filename
39572 752 8792 49116 bfdc bin/PingPongUc

PingPongC:
text data bss dec hex filename
46044 872 360 47276 b8ac bin/PingPongC

ReactionLatencyUc:
text data bss dec hex filename
29601 736 2080 32417 7ea1 bin/ReactionLatencyUc

ReactionLatencyC:
text data bss dec hex filename
41666 840 360 42866 a772 bin/ReactionLatencyC

@LasseRosenow LasseRosenow force-pushed the simplify-network-channel-interface branch from 3a6aac2 to 96e37a1 Compare December 3, 2024 13:28
@LasseRosenow LasseRosenow force-pushed the simplify-network-channel-interface branch from 94c04e4 to 878a945 Compare December 3, 2024 17:29
opts = (opts & (~O_NONBLOCK));
} else {
opts = (opts | O_NONBLOCK);
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed anymore since we can just always block inside of the TcpIpChannel now. It also makes handling the state more easy. The runtime is not blocked by it anymore.

@LasseRosenow
Copy link
Collaborator Author

This branch diverged too much from the one it depended on. Rebasing proofed difficult so I will reopen a new branch with the changes

@LasseRosenow LasseRosenow deleted the simplify-network-channel-interface branch December 5, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants