Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup pass on Cpp examples and navigation #98

Merged
merged 8 commits into from
Feb 10, 2024
Merged

Cleanup pass on Cpp examples and navigation #98

merged 8 commits into from
Feb 10, 2024

Conversation

edwardalee
Copy link
Contributor

@edwardalee edwardalee commented Jan 31, 2024 •
edited
Loading

I have added README files to navigate the examples and done a bunch of cleanup. But more cleanup is needed. See issue #99.

@edwardalee edwardalee requested a review from cmnrd January 31, 2024 01:29
@edwardalee edwardalee mentioned this pull request Jan 31, 2024
Open
cmnrd
cmnrd reviewed Feb 6, 2024
View reviewed changes
Copy link
Contributor

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these cleanups! Should we perhaps avoid the extra layer of indirection presented by the <target>/README.md files and list all examples directly in the top-level README? Then they would also become visible on the main page of the repo.

examples/README.md Show resolved Hide resolved
examples/Cpp/AlarmClock/src/README.md Show resolved Hide resolved
@cmnrd
Copy link
Contributor

cmnrd commented Feb 6, 2024

I pushed an update to the main .gitignore file which addresses the problem mentioned in #99.

@edwardalee edwardalee merged commit ea183b5 into main Feb 10, 2024
5 checks passed
@edwardalee
Copy link
Contributor Author

I am going ahead and merging this even though there is more work to be done because I think the current status of the playground is misleading and may even be off-putting.

@edwardalee edwardalee deleted the cpp-examples branch February 10, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmnrd cmnrd cmnrd left review comments

Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwardalee @cmnrd