Implement draft #13
Draft
Implement draft #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoey1124
commented
Aug 18, 2022
zoey1124
commented
- Fully implement Python version of ConcurrentAdder
- Finish draft for SharedList
* Fully implement Python version of ConcurrentAdder * Finish draft for SharedList
edwardalee
reviewed
Aug 18, 2022
There was a problem hiding this comment.
The SharedList looks like the start of a design where a list is passed around among reactors that modify the list. An alternative design that might be more consistent with the name "SharedList" is one where a number of reactors maintain a copy of a shared list and instead of passing around the list, they pass around their modifications to the list. See C/src/DistributedDatabase/ReplicatedDatabase.lf in the examples repo for an illustration of such a design.
|
|
||
| main reactor(stride(10), period(1 sec), N(4)) { | ||
| c = new Counter(stride=stride, period=period); | ||
| a = new[4] Adder(); |
There was a problem hiding this comment.
Is this meant to be
a = new[N] Adder();
| =} | ||
| } | ||
|
|
||
| reactor Adder(bank_value(1)) { |
There was a problem hiding this comment.
Is this meant to be bank_index rather than bank_value?
| @@ -0,0 +1,54 @@ | |||
| ''' | |||
| This is a shared itemlist for multiple people | |||
| to appendItem or deltetItem at the same time | |||
There was a problem hiding this comment.
Suggested change
| to appendItem or deltetItem at the same time | |
| to appendItem or deltetItem at the same time. |
| c = new Counter(stride = 1) | ||
| p = new Printer() | ||
| c.out -> p._in | ||
| } |
| p = new Printer(N=N); | ||
| (c.out)+ -> a._in; | ||
| a.out -> p._in; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.