-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix examples for release 0.7.0 #104
Conversation
2400814
to
53bd7f4
Compare
53bd7f4
to
0db31bb
Compare
0db31bb
to
71a79d0
Compare
@edwardalee I fixed the cmake issues, but now the linker complains in the ROS and MQTT examples. It is missing a reference to |
Just pushed updates to replace LF_SET_ARRAY. |
The memory management indeed looks suspicious. However, I don't understand the current implementation of tokens (and in particular its assumptions) well enough to comment on it. Should we go ahead and merge this or wait for the 0.7.0 release? Some of the changes are incompatible with 0.6.0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge.
It won't be ready to merge until we release |
We are in an inconsistent state anyway... Currently, the playground neither works with 0.6.0 nor with the current master. If we merge this, it will at least work with master. |
This PR updates the examples to be ready for the 0.7.0 release. This release introduces a couple of breaking changes and the examples need to be adjusted accordingly.
Fixes #103