Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing #38

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Testing #38

merged 2 commits into from
Nov 14, 2023

Conversation

tanneberger
Copy link
Member

@tanneberger tanneberger commented Sep 26, 2023

Things Done

  • CI
    • Running Tests for CPP, NPM and LFC backends
  • Fixed a lot of bugs that were discovered by the ci
  • Added the keep-alive flag

Future Work

  • Typescript: Building of Federations
  • Typescript: Serialization
  • Cpp: Fixing Include Paths
  • Race Condition when using parallel builds: Compiling of sources potentially starts before src-gen finishes

Fixes #42.

@tanneberger tanneberger force-pushed the testing branch 28 times, most recently from b766452 to 484e18a Compare September 26, 2023 13:03
@lhstrh lhstrh changed the title [DRAFT] Testing Testing Sep 30, 2023
test.sh Outdated Show resolved Hide resolved
@tanneberger
Copy link
Member Author

The CPP Tests are failing becuase the wrong path is in
LF_SRC_PKG_PATH:UNINITIALIZED=/home/revol-xut/workspace/lf/lingua-franca/test

It should always point to the src dir

@lhstrh lhstrh added this to the Initial Release milestone Oct 10, 2023
test/Lingo-TypeScript.toml Outdated Show resolved Hide resolved
@tanneberger tanneberger force-pushed the testing branch 4 times, most recently from 9cf60aa to 889dbbf Compare November 2, 2023 15:47
@lhstrh
Copy link
Member

lhstrh commented Nov 6, 2023

What is the status of this PR, @tanneberger?

@tanneberger
Copy link
Member Author

@lhstrh Last Thing I did this weekend was looking into why the typescript CI is still red, and I think its the dockerized tests.

@tanneberger
Copy link
Member Author

tanneberger commented Nov 9, 2023

Okay, the next problem with the typescript target is that the federated code gen is dropped under fed-gen and not src-gen.
Is the fed-gen folder so structurally different from the src-gen folder that its not feasible to remove the fed-gen folder ? @lhstrh

@lhstrh
Copy link
Member

lhstrh commented Nov 9, 2023

Okay, the next problem with the typescript target is that the federated code gen is dropped under fed-gen and not src-gen. Is the fed-gen folder so structurally different from the src-gen folder that its not feasible to remove the fed-gen folder ? @lhstrh

Yes, it is. The fed-gen/src folder actually has generated LF code in it, which is then compiled down to target code in a second step.

@tanneberger
Copy link
Member Author

tanneberger commented Nov 9, 2023

@lhstrh Would it be possible to rename fed-gen to src-gen

No, there is an src-gen in fed-gen subtree for each federate as well. It is different from the src-gen in the root.

@tanneberger tanneberger force-pushed the testing branch 3 times, most recently from 62f42a7 to 39ad982 Compare November 13, 2023 10:42
@tanneberger tanneberger force-pushed the testing branch 2 times, most recently from 87eb2a6 to 24e5bb3 Compare November 13, 2023 13:40
@tanneberger tanneberger requested a review from lhstrh November 13, 2023 16:26
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I think we should address the remaining Clippy warnings before merging though...

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was only able to do a spot check because I'm not a Rust expert, but this looks good to me!

@tanneberger tanneberger merged commit 9fa9c7e into main Nov 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lingo run returns with - Main: Success even when the program exits with error
2 participants