downstreaming sha1dir #88
tannebergerci.yaml
on: pull_request
CPP Test
1m 18s
TypeScript Test
1m 21s
LFC Fallback Test
1m 18s
Annotations
1 error and 17 warnings
|
read amount is not handled:
src/util/sha1dir.rs#L87
error: read amount is not handled
--> src/util/sha1dir.rs:87:5
|
87 | f.read(&mut buffer).expect("buffer overflow");
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: use `Read::read_exact` instead, or handle partial reads
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
= note: `#[deny(clippy::unused_io_amount)]` on by default
|
|
the borrowed expression implements the required traits:
src/util/sha1dir.rs#L85
warning: the borrowed expression implements the required traits
--> src/util/sha1dir.rs:85:33
|
85 | let metadata = fs::metadata(&filename).expect("unable to read metadata");
| ^^^^^^^^^ help: change this to: `filename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
|
|
the borrowed expression implements the required traits:
src/util/sha1dir.rs#L84
warning: the borrowed expression implements the required traits
--> src/util/sha1dir.rs:84:28
|
84 | let mut f = File::open(&filename).expect("no file found");
| ^^^^^^^^^ help: change this to: `filename`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
the following explicit lifetimes could be elided: 'a:
src/util/command_line.rs#L18
warning: the following explicit lifetimes could be elided: 'a
--> src/util/command_line.rs:18:6
|
18 | impl<'a, W0: Write, W1: Write> Write for TeeWriter<'a, W0, W1> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
18 - impl<'a, W0: Write, W1: Write> Write for TeeWriter<'a, W0, W1> {
18 + impl<W0: Write, W1: Write> Write for TeeWriter<'_, W0, W1> {
|
|
|
the following explicit lifetimes could be elided: 'de:
src/package/mod.rs#L296
warning: the following explicit lifetimes could be elided: 'de
--> src/package/mod.rs:296:6
|
296 | impl<'de> Visitor<'de> for VersioningVisitor {
| ^^^ ^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
help: elide the lifetimes
|
296 - impl<'de> Visitor<'de> for VersioningVisitor {
296 + impl Visitor<'_> for VersioningVisitor {
|
|
|
the following explicit lifetimes could be elided: 'a:
src/backends/lfc.rs#L107
warning: the following explicit lifetimes could be elided: 'a
--> src/backends/lfc.rs:107:6
|
107 | impl<'a> Display for LfcJsonArgs<'a> {
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
|
107 - impl<'a> Display for LfcJsonArgs<'a> {
107 + impl Display for LfcJsonArgs<'_> {
|
|
|
CPP Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
CPP Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
CPP Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
CPP Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
LFC Fallback Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
LFC Fallback Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
LFC Fallback Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
LFC Fallback Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
TypeScript Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
TypeScript Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
TypeScript Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
TypeScript Test
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|