Merge pull request #139 from NN---/patch-2

Add less than or equal and greater than or equal operators to ObjectIdentifier
lextudio · Apr 8, 2023 · 3e07e8b · 3e07e8b
2 parents f0e5d87 + 84305e9
commit 3e07e8b
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 0 deletions.
diff --git a/SharpSnmpLib/ObjectIdentifier.cs b/SharpSnmpLib/ObjectIdentifier.cs
@@ -451,6 +451,17 @@ public override int GetHashCode()
         {
             return left.CompareTo(right) > 0;
         }
+
+        /// <summary>
+        /// Implements the operator &gt;=.
+        /// </summary>
+        /// <param name="left">The left.</param>
+        /// <param name="right">The right.</param>
+        /// <returns>The result of the operator.</returns>
+        public static bool operator >=(ObjectIdentifier left, ObjectIdentifier right)
+        {
+            return left.CompareTo(right) >= 0;
+        }
 
         /// <summary>
         /// Implements the operator &gt;=.
@@ -485,6 +496,17 @@ public override int GetHashCode()
             return left.CompareTo(right) <= 0;
         }
 
+        /// <summary>
+        /// Implements the operator &lt;=.
+        /// </summary>
+        /// <param name="left">The left.</param>
+        /// <param name="right">The right.</param>
+        /// <returns>The result of the operator.</returns>
+        public static bool operator <=(ObjectIdentifier left, ObjectIdentifier right)
+        {
+            return left.CompareTo(right) <= 0;
+        }
+
         /// <summary>
         /// The comparison.
         /// </summary>

diff --git a/Tests/CSharpCore/Unit/ObjectIdentifierTestFixture.cs b/Tests/CSharpCore/Unit/ObjectIdentifierTestFixture.cs
@@ -76,6 +76,22 @@ public void TestGreaterThan()
             Assert.True(new ObjectIdentifier("0.0").Compare(new ObjectIdentifier("1.1")) < 0);
         }
 
+        [Fact]
+        public void TestGreaterThanOrEqual()
+        {
+            Assert.True(new ObjectIdentifier("1.1") >= new ObjectIdentifier("0.0"));
+            Assert.True(new ObjectIdentifier("1.1") >= new ObjectIdentifier("1.1"));
+            Assert.True(new ObjectIdentifier("0.0.0") >= new ObjectIdentifier("0.0"));
+        }
+
+        [Fact]
+        public void TestLessThanOrEqual()
+        {
+            Assert.True(new ObjectIdentifier("0.0") <= new ObjectIdentifier("1.1"));
+            Assert.True(new ObjectIdentifier("1.1") <= new ObjectIdentifier("1.1"));
+            Assert.True(new ObjectIdentifier("0.0") <= new ObjectIdentifier("0.0.0"));
+        }
+
         [Fact]
         public void TestConversion()
         {