-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[P167] Enable use of SEN5x sensor, other improvements #5038
[P167] Enable use of SEN5x sensor, other improvements #5038
Conversation
@saint-hh You might be interested in testing this 😉 please report your findings here. |
Gorgeous, will do! |
…feature/P167-add-support-for-standalone-sen5x-sensor
On ESP32 I usually see a higher load then on ESP8266, that partially depends on what plugins are active, but is nothing to worry about, as long as it's not constantly near 100%. |
I'm very interested how system will work with 2 SEN5x devices on the same i2c bus using a i2c multiplexer, some print screens with Devices page will be very interesting. |
@andibaciu Have you tested this code on an actual Ikea Vindstyrka device? As I don't own such device, I can't verify myself if it still works as intended. |
I'll test this version on IKEA Vindstyrka later today (I saw this post with modification/improvements a few hours ago), but give me a hint about configuring second task .... i understand there are 2 methods .... |
Well, there is actually just 1 method: Configure exactly 1 task per device. In your specific situation, it might be best to disable the existing tasks, and configure a new task with this version of the plugin, or your configuration might get lost (unless you backup your config, to later restore when returning to your current ESPEasy version). |
…feature/P167-add-support-for-standalone-sen5x-sensor
Hmm, that seems to be a recurring issue I have with these checkboxes (completely my fault, usually 😊), I'll fix that soon. |
@tonhuisman , For me still don't work Technical logging ... when i press "Submit" check state disapear ... |
…feature/P167-add-support-for-standalone-sen5x-sensor
I've installed the ESP8266 Climate build on a Wemos D1 clone, and the checkbox for Technical logging is working here as intended (was testing a MAX build before, and ESP32 is sometime a little bit more forgiving in this area). |
@tonhuisman if i change this lines: 222 //addFormCheckBox(F("Technical logging"), P167_ENABLE_LOG_LABEL, P167_ENABLE_LOG); 236 //P167_ENABLE_LOG = isFormItemChecked(P167_ENABLE_LOG_LABEL); 262 Plugin_167_SEN->setLogging(P167_ENABLE_LOG); everithing work ok with check button. |
…feature/P167-add-support-for-standalone-sen5x-sensor
Can't explain it (yet) but using |
@andibaciu Are you (or where you) using the sourcecode of an older release of ESPEasy, with additionally the files for this plugin? |
@tonhuisman i work with this release "Changes in release mega-20240229 (since mega-20231225)" ... before i make my firts commit for P167 .... |
Yep back then it wasn't fixed as I did fix it about a month ago in the ESPEasy core files. |
I apologize for the mistake Now i update my local version of mega to last version and everything is ok with check button with first version of files. |
…feature/P167-add-support-for-standalone-sen5x-sensor
I've found a typo in the definition of the The (AFAICS) unexpected background color change may be related to an issue with the background color not working as expected, I fixed a couple of months ago in the same overhaul of the AdafruitGFX_Helper module that is used for most display plugins, but I'll have to investigate what the exact cause here is. The offset in positioning is probably also related to bugs I fixed when working on that helper module, some fonts used a different 0-point than others, AFAIR. |
Ah - that might also explain why I had to sort the positions with trial&error and couldn't really sort it out logically. Somehow position of text and images, boxes etc were not logically matching in numbers to me.
For the time in the upper right corner I use robotomono8pt, for the rest I use amerikasans16pt |
Have you already shared your rules files somewhere? I can't find them in the forum threads. |
Yes, here you go: It changed a little bit, but basically this is it. |
Additionally: When using the same color for background and foreground, results in the background being transparent, that should get rid of the current dark-blue background. The positioning of the text depends on the font definition (some fonts are offset vertically by half or full font-height 😱), I'm quite sure it is now working as originally intended, and as you stated it was quite fiddly to get it right, most likely it will start to work correct once I push my fixes (did a lot of testing last night). This may require you to adjust your rules slightly, as the coordinates will match with coordinates for lines, images etc. I corrected a few of the font definitions. Will make a commit in the other PR, and cherry pick that here too (the small fix I mentioned yesterday isn't yet pushed, but also won't make a difference here). |
That sounds good - thank you!
Should we, in order to keep it clean (no SEN5X plugin problem), continue in the related PR? Which one is it? I've flashed the device for my wife's office back to the 22.04. build. She took it with her today. But I can test and adjust on my device home. |
I can't cherry-pick the changes here without mixing/fighting in a lot of changes from 'the other PR', so we'd better continue this 'over there' in #4016 |
@andibaciu It seems I kind of ignored your question here, but that's not intentional. We have extensive documentation on how to configure an I2C multiplexer in ESPEasy, here. Having multiple SEN5x sensors on the same ESP isn't the best choice, as I2C wiring should be short (max 30 cm), and measuring air quality roughly half a meter apart with 2 of these sensors isn't going to add much value... but it will work, if only to compare measurements 😄 but you could install 1 in two separate, adjacent, rooms with the ESP in between 👍 |
@tonhuisman - if there are 2 SEN5x devices attached to an i2c multiplexer, I would like to know how many tasks must be declared - one for each device? |
Yes, from ESPEasy perspective they are 2 independent hardware devices, that need their own separate configuration. |
…https://github.com/tonhuisman/ESPEasy-1 into feature/P167-add-support-for-standalone-sen5x-sensor
Resolves #4794 phase 2: Stand-alone SEN5x support
Features:
Climate
andMAX
buildssen5x,startclean
command to clean the fansen5x,techlog,<0|1>
command to disable/enable the Technical logging optionTODO: