Allow subclasses to override the deserialization logic #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -394,7 +394,7 @@ static PyObject *_PylibMC_parse_memcached_value(char *value, size_t size, | |||
|
|
|||
| switch (dtype) { | |||
| case PYLIBMC_FLAG_PICKLE: | |||
| retval = _PylibMC_Unpickle(value, size); | |||
| retval = PyObject_CallMethod((PyObject *)self, "deserialize", "s#", value, size); | |||
There was a problem hiding this comment.
Could you extend the callback method to pass in the flags too? This would allow PHP memcached (and other) implementations to inspect the memcached flags for deserialization.
There was a problem hiding this comment.
I don't know how.
Feel free to fork / edit / pull request.
|
Very nice work! I am however skeptical of a couple of things that I think we should at least discuss before going further:
|
This was referenced Sep 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches #96
I've added a unit test which demonstrates how this can be used to transform unpickling errors to cache misses. This is implemented by refactoring the
_PylibMC_Unpicklefunction to be a method:Client.deserialize.I imagine the next logical step is to do the same refactorization for
_PylibMC_Pickle/serialize, but the project is in a fully usable state as-is, and this change closes our issue. Allowing overrides to both serialize/deserialize will close a couple of your other issues: "Custom Pickler implementations", "It should be possible to specify pickle protocol version".