Opt in locations in release mode with --cfg locations #3281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you happy with the name |
zakstucke
force-pushed
the
opt-in-release-locations
branch
from
2a17515 to
3c05ec9
Compare
|
@gbj any chance of getting this one merged? Should be good to go other than any name bikeshedding 😁 |
|
Yep sorry — just read it over and this looks good to me. As far as a name: Maybe something like |
zakstucke
force-pushed
the
opt-in-release-locations
branch
from
3c05ec9 to
7ecc809
Compare
|
No worries! Just switched it over to |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.