Allow CDN_PKG_PATH at runtime. #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng it when available.
|
I would lean towards a solution that kept the env var check during compile time, and could be overriden by an env var at runtime. This way both users get what they want |
|
@benwis could you elaborate? I read what you're saying to be exactly how I implemented it. Before: After: |
|
I think you're right, I made a mistake with that. Jet lagged 8 hours in London is not helping. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements runtime support for CDN_PKG_PATH, preferring it when available.
Beforehand, only build time would be read.
Why
In my case, my cdn path is categorised as a sensitive key, therefore only available at runtime later than the build stage.