Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

router: Fix router forgetting about state (fixes #2164) #2165

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

luxalpa
Copy link
Contributor

@luxalpa luxalpa commented Jan 6, 2024

I am pulling the "State" field in a similar manner to the other location fields within BrowserIntegration::current(). I also changed the State serialization for None from UNDEFINED to NULL as the latter is the default in browsers and should be more consistent. I am not sure what the reason was to originally use undefined and State(None).

@gbj
Copy link
Collaborator

gbj commented Jan 6, 2024

Thanks! I've never used state myself, it was just part of the original port of the router, so I can guarantee there was not a good reason. Most of the state stuff was // TODO for a long time so apologies if you run into additional issues.

@gbj
Copy link
Collaborator

gbj commented Jan 6, 2024

Failing tests are due to new clippy warnings outside this PR caused by new nightly clippy. I addressed those in #2169 — would you mind rebasing onto main so the CI will run again?

@gbj gbj merged commit 10bbeea into leptos-rs:main Jan 11, 2024
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants