Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'a lifetime are not linking input params to the output. Should be replaced by static #2125

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

martinfrances107
Copy link
Contributor

to reprodce this clippy warning

cd leptos/leptos_macro/example
cargo clippy

warning: the following explicit lifetimes could be elided: 'a
--> src/lib.rs:41:20
|
41 | fn TestMutCallback<'a, F>(mut callback: F, value: &'a str) -> impl IntoView
| ^^ ^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
= note: #[warn(clippy::needless_lifetimes)] on by default
help: elide the lifetimes
|
41 - fn TestMutCallback<'a, F>(mut callback: F, value: &'a str) -> impl IntoView
41 + fn TestMutCallback(mut callback: F, value: &str) -> impl IntoView
|

warning: example (lib) generated 1 warning (run cargo clippy --fix --lib -p example to apply 1 suggestion)

```bash
cd leptos/leptos_macro/example
cargo clippy
```

warning: the following explicit lifetimes could be elided: 'a
  --> src/lib.rs:41:20
   |
41 | fn TestMutCallback<'a, F>(mut callback: F, value: &'a str) -> impl IntoView
   |                    ^^                              ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
   = note: `#[warn(clippy::needless_lifetimes)]` on by default
help: elide the lifetimes
   |
41 - fn TestMutCallback<'a, F>(mut callback: F, value: &'a str) -> impl IntoView
41 + fn TestMutCallback<F>(mut callback: F, value: &str) -> impl IntoView
   |

warning: `example` (lib) generated 1 warning (run `cargo clippy --fix --lib -p example` to apply 1 suggestion)
@gbj gbj merged commit 34fb39c into leptos-rs:main Dec 21, 2023
59 checks passed
@martinfrances107 martinfrances107 deleted the leptos_macro_example branch December 21, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants