docs: move to table of features for leptos
#2044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thought this did something for linking to crates by name. Forgot to delete it
gbj
reviewed
Nov 24, 2023
| //! | rustls[^2] | **Networking**: Use [rustls]. | No | | ||
| //! | template_macro | **Templating**: Enables the legacy [template] macro. | No | | ||
| //! | ||
| //! [^1]: At least one **rendering** feature must be enabled. An Isomorphic crate may have |
There was a problem hiding this comment.
This rewritten version sounds misleading to me. Exactly one should be enabled, not more than one.
|
I like this overall, and thank you for it! I would prefer to keep the original wording about using one of |
|
Hey! I see your recommendations and you are correct. I'm a little overwhelmed with work at the moment but plan to revisit and correct this when I have the time. Thanks for the feedback. I am going to move this to a draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cosmetic change and may be opinionated. I find tables like this to be more readable.
For some it can be hard to parse without visual organization. No issue at all if it does not fall into line with your view for the docs.
I would not mind unifying the other crates if merged
here it is rendered on my local machine without any styles that docs.rs might add.
