Have fetch example conform to docs guidance around using <ErrorBoundary> and <Transition> in conjunction #2035
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs state that when used in conjunction,
<ErrorBoundary>
should be inside<Transition>
, not the other way around. This didn't have a functional effect on the fetch example because it happens to usecreate_local_resource
which guarantees that the resource will be loaded on the client side. https://docs.rs/leptos/latest/leptos/fn.ErrorBoundary.html#interaction-with-suspenseBut I was working on an application that uses
create_resource
, and I happened to be using this example as a model of using<ErrorBoundary>
and<Transition>
in conjunction. When server side rendering is a possibility, reversing them seems to cause an issue where the<ErrorBoundary>
fallback doesn't render properly.So I thought maybe we should use them in the recommended order in this example.