Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: stop using std::fmt, instead used core::fmt. #2033

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

martinfrances107
Copy link
Contributor

@martinfrances107 martinfrances107 commented Nov 16, 2023

This is a coding standard, I have adopted in my own libraries, and well this is open source, so I want to start using this practice in modules that I use on a regular basis too..

It follows a recent trend in the rust community.

It is a aspiration, rather than an achievable goal - One day someone will try and run my library of an IOT device
and I will have to answer question on the lines of

What portions of the library can I still use in a "no_std" environment.

So the is a defensive change .. and to drop std::fmt and use core::fmt where possible

I hope this helps.

@gbj
Copy link
Collaborator

gbj commented Nov 17, 2023

Huh, that's interesting. There is no plausible path to no_std for Leptos, but seems like good practice overall!

@gbj gbj merged commit 362e3bc into leptos-rs:main Nov 17, 2023
58 checks passed
@martinfrances107 martinfrances107 deleted the core_fmt branch March 24, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants