Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR that updates the Nix build system to use a recentish commit from Nixpkgs that has more recent versions of Rust Nightly. Specifically
rustc 1.75.0-nightly (a2f5f9691 2023-11-02)
It also moves away from using Nix flakes and uses Nix shell for the following reasons:
rust-toolchain.toml
filedefault.nix
pins the dependencies to a specific commit ensuring that build dependencies aren't automatically updated when the upstream repositories get updated. The commit is the most recent commit that passes all tests from the Nixpkgs repo. Future updates just need to bump the commit version to another recent version that passes all testsPerforming a couple of additional checks before this is ready to merge