Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix builds on Nix #1978

Closed
wants to merge 1 commit into from

Conversation

saikatdas0790
Copy link
Contributor

@saikatdas0790 saikatdas0790 commented Nov 3, 2023

This is a draft PR that updates the Nix build system to use a recentish commit from Nixpkgs that has more recent versions of Rust Nightly. Specifically rustc 1.75.0-nightly (a2f5f9691 2023-11-02)

It also moves away from using Nix flakes and uses Nix shell for the following reasons:

  • Nix flakes are still experimental while Nix shell is stable and mature tooling
  • The current Nix flake uses a Rust overlay which is an additional component that needs to be added. This pull request uses native cargo tooling and puts the toolchain specific particulars in a rust-toolchain.toml file
  • The default.nix pins the dependencies to a specific commit ensuring that build dependencies aren't automatically updated when the upstream repositories get updated. The commit is the most recent commit that passes all tests from the Nixpkgs repo. Future updates just need to bump the commit version to another recent version that passes all tests

Performing a couple of additional checks before this is ready to merge

@saikatdas0790 saikatdas0790 deleted the fix-nix-builds branch November 3, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant