Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added Callback to documentation and examples. #1926

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Conversation

maccesch
Copy link
Contributor

Also reduced code duplication in Callback implementation.

@maccesch
Copy link
Contributor Author

@gbj The failing CI is not from my code

@gbj
Copy link
Collaborator

gbj commented Oct 24, 2023

Thanks, looks great!

@gbj gbj merged commit e2f6780 into leptos-rs:main Oct 24, 2023
44 of 60 checks passed
@maccesch
Copy link
Contributor Author

Oh I now have the Callback before the Fn() option. I figured that after the discussons in Discord you'd probably want me to reverse that order?

@gbj
Copy link
Collaborator

gbj commented Oct 24, 2023

Don't worry about it, I can go in and rearrange them if I'd like!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants