Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minimize features activated with leptos_axum's default feature #1846

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

k9withabone
Copy link
Contributor

@k9withabone k9withabone commented Oct 5, 2023

Closes #1835. I had to edit a couple of examples' tokio features to get them to work. Unfortunately, I think this means that this a breaking change, per the cargo book.

  • leptos_axum default feature:
    • remove tokio/full, axum/macros
    • add tokio/fs, tokio/sync
  • example leptos-tailwind-axum:
    • enable tokio's rt-multi-thread and macros features
  • example ssr_modes_axum:
    • enable tokio's rt-multi-thread and macros features

@gbj
Copy link
Collaborator

gbj commented Oct 6, 2023

Yes, this makes it a breaking change, as it would require users to enable additional Tokio features in a patch release, in a similar way to the examples. Totally fine to queue this up for 0.6, whenever it comes, but seeing as I released 0.5 on Saturday that's unlikely to be any time soon. But thanks for the PR.

@gbj gbj added this to the 0.6 milestone Oct 6, 2023
@gbj gbj modified the milestones: 0.7, 0.6 Jan 4, 2024
@benwis benwis changed the base branch from main to leptos_v0.6 January 13, 2024 16:25
@k9withabone
Copy link
Contributor Author

Do you want me to rebase this so that it can be merged?

@gbj
Copy link
Collaborator

gbj commented Jan 17, 2024

Yes, please, that would be great!

- `leptos_axum` default feature:
  - remove `tokio/full`, `axum/macros`
  - add `tokio/fs`, `tokio/sync`
- example `leptos-tailwind-axum`:
  - enable `tokio`'s `rt-multi-thread` and `macros` features
- example `ssr_modes_axum`:
  - enable `tokio`'s `rt-multi-thread` and `macros` features
@k9withabone
Copy link
Contributor Author

Should be good to go now.

@gbj gbj merged commit 50303ab into leptos-rs:leptos_v0.6 Jan 20, 2024
@gbj
Copy link
Collaborator

gbj commented Jan 20, 2024

Thanks!

@gbj gbj mentioned this pull request Jan 20, 2024
@k9withabone k9withabone deleted the leptos_axum/deps branch January 21, 2024 01:12
@k9withabone
Copy link
Contributor Author

Looks like this didn't get merged into main when you merged #2158.

@k9withabone k9withabone restored the leptos_axum/deps branch January 21, 2024 01:17
@gbj
Copy link
Collaborator

gbj commented Jan 21, 2024

Thanks — I missed the fact that it had been retargeted from main to the 0.6 branch, and was merged into 0.6 after I'd merged 0.6 into main. I'm opening a new PR to just move that commit over to the main branch from the 0.6 branch; your branch should be safe to delete.

gbj added a commit that referenced this pull request Jan 21, 2024
…re (#1846) (#2213)

- `leptos_axum` default feature:
  - remove `tokio/full`, `axum/macros`
  - add `tokio/fs`, `tokio/sync`
- example `leptos-tailwind-axum`:
  - enable `tokio`'s `rt-multi-thread` and `macros` features
- example `ssr_modes_axum`:
  - enable `tokio`'s `rt-multi-thread` and `macros` features

Co-authored-by: Paul Nettleton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

leptos_axum uses tokio/full
2 participants