fix: correctly reset hydration status in islands mode Suspense (closes …

…#2332) (#2393)
leptos-rs · Mar 2, 2024 · 9fd2987 · 9fd2987
1 parent 7996f83
commit 9fd2987
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 4 deletions.
diff --git a/leptos/src/suspense_component.rs b/leptos/src/suspense_component.rs
@@ -173,14 +173,17 @@ where
                                         runtime,
                                     );
 
+                                    #[cfg(feature = "experimental-islands")]
+                                    let prev_no_hydrate =
+                                        SharedContext::no_hydrate();
                                     #[cfg(feature = "experimental-islands")]
                                     {
                                         SharedContext::set_no_hydrate(
                                             no_hydrate,
                                         );
                                     }
 
-                                    with_owner(owner, {
+                                    let rendered = with_owner(owner, {
                                         move || {
                                             HydrationCtx::continue_from(
                                                 current_id,
@@ -194,7 +197,15 @@ where
                                             .render_to_string()
                                             .to_string()
                                         }
-                                    })
+                                    });
+
+                                    #[cfg(feature = "experimental-islands")]
+                                    SharedContext::set_no_hydrate(
+                                        prev_no_hydrate,
+                                    );
+
+                                    #[allow(clippy::let_and_return)]
+                                    rendered
                                 }
                             },
                             // in-order streaming
@@ -205,14 +216,17 @@ where
                                         runtime,
                                     );
 
+                                    #[cfg(feature = "experimental-islands")]
+                                    let prev_no_hydrate =
+                                        SharedContext::no_hydrate();
                                     #[cfg(feature = "experimental-islands")]
                                     {
                                         SharedContext::set_no_hydrate(
                                             no_hydrate,
                                         );
                                     }
 
-                                    with_owner(owner, {
+                                    let rendered = with_owner(owner, {
                                         move || {
                                             HydrationCtx::continue_from(
                                                 current_id,
@@ -225,7 +239,15 @@ where
                                             .into_view()
                                             .into_stream_chunks()
                                         }
-                                    })
+                                    });
+
+                                    #[cfg(feature = "experimental-islands")]
+                                    SharedContext::set_no_hydrate(
+                                        prev_no_hydrate,
+                                    );
+
+                                    #[allow(clippy::let_and_return)]
+                                    rendered
                                 }
                             },
                         );

diff --git a/leptos_reactive/src/hydration.rs b/leptos_reactive/src/hydration.rs
@@ -339,11 +339,13 @@ thread_local! {
 impl SharedContext {
     /// Whether the renderer should currently add hydration IDs.
     pub fn no_hydrate() -> bool {
+        println!("no_hydrate == {}", NO_HYDRATE.with(Cell::get));
         NO_HYDRATE.with(Cell::get)
     }
 
     /// Sets whether the renderer should not add hydration IDs.
     pub fn set_no_hydrate(hydrate: bool) {
+        println!("set_no_hydrate == {}", hydrate);
         NO_HYDRATE.with(|cell| cell.set(hydrate));
     }