Collection of minor changes #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blorbb
commented
Feb 11, 2024
|
|
||
| In the current version of Leptos (in fact in Leptos 0.1-0.5), creating a dynamic child | ||
| In the current version of Leptos (in fact in Leptos 0.1-0.6), creating a dynamic child |
There was a problem hiding this comment.
Updated this version, I think it probably hasn't changed in 0.6 but I haven't checked.
|
@blorbb This all looks great, and thanks very much for taking the time 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes based on #48.
with!macros; first part of Leptos Book - Reader Feedback: Please Comment Here #48 (comment) from @ydirsonSubmitEventcomes from, first part of Leptos Book - Reader Feedback: Please Comment Here #48 (comment) from @cldershem(P.S. @diversable, maybe having one thread for tracking minor issues isn't the best, it's hard to search can't and keep track of which parts have been completed. Perhaps just encourage readers to create their own issue?)