Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix new axum version incompatibility #20

Merged
merged 4 commits into from
Nov 29, 2024
Merged

Fix new axum version incompatibility #20

merged 4 commits into from
Nov 29, 2024

Conversation

leotaku
Copy link
Owner

@leotaku leotaku commented Nov 20, 2024

If I understand #19 correctly, this should cause our integration tests to fail.

@leotaku
Copy link
Owner Author

leotaku commented Nov 25, 2024

This seems like a reasonable compromise. Updating Content-Length when it is set and ignoring it otherwise. @ankush what do you think?

@ankush
Copy link

ankush commented Nov 26, 2024

That sounds good to me. though I don't know much about the internals of axum, hyper, and other frameworks 😅

@leotaku leotaku changed the title Update axum in integration tests Fix new axum version incompatibility Nov 29, 2024
@leotaku
Copy link
Owner Author

leotaku commented Nov 29, 2024

This seems good to me still. I will merge and cut a new release.

@leotaku leotaku merged commit 116f07b into master Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants