-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): add flag to commit to signal VSTS CI servers to ignore the… #55
feat(app): add flag to commit to signal VSTS CI servers to ignore the… #55
Conversation
… commit This avoid VSTS CI servers running another build due to changes related to versioning ISSUES CLOSED: #54
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Do you think we need a section on readme file explaining the commit skips?
I think we should raise a ticket with Vsts to change their commit slip since they are the only different one.
It should help, I only discovered this function after the first test, would it be good to include it in the FAQ section? There is an issue in vsts-agent #858, also posted it in their ticket system, I really need this to continue my work in VSTS, since it's building twice, I'll open another issue there talking about it there. |
Sure! I merge it now then we track vsts issue. We update readme in separate pr |
Okay, waiting for the release to test it out, thanks! |
It’s supposed to release automatically after every commit merged into master. I don’t know why it didn’t release. I’ll have to investigate tomorrow |
No problem, this should help semantic-release/semantic-release#347 |
Seems that the node 8 version have to be the build leader to publish, or use some build stages to make it work properly |
… commit
This avoid VSTS CI servers running another build due to changes related to versioning
ISSUES CLOSED: #54