Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add flag to commit to signal VSTS CI servers to ignore the… #55

Merged
merged 1 commit into from
Oct 30, 2017
Merged

feat(app): add flag to commit to signal VSTS CI servers to ignore the… #55

merged 1 commit into from
Oct 30, 2017

Conversation

marceloavf
Copy link
Contributor

… commit

This avoid VSTS CI servers running another build due to changes related to versioning

ISSUES CLOSED: #54

… commit

This avoid VSTS CI servers running another build due to changes related to versioning

ISSUES CLOSED: #54
@coveralls
Copy link

coveralls commented Oct 27, 2017

Coverage Status

Coverage remained the same at 93.469% when pulling 953a789 on marceloavf:feature/allow-vsts-skip-ci into 1373330 on leonardoanalista:master.

Copy link
Owner

@leonardoanalista leonardoanalista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Do you think we need a section on readme file explaining the commit skips?
I think we should raise a ticket with Vsts to change their commit slip since they are the only different one.

@marceloavf
Copy link
Contributor Author

marceloavf commented Oct 30, 2017

It should help, I only discovered this function after the first test, would it be good to include it in the FAQ section?

There is an issue in vsts-agent #858, also posted it in their ticket system, I really need this to continue my work in VSTS, since it's building twice, I'll open another issue there talking about it there.

@leonardoanalista
Copy link
Owner

Sure! I merge it now then we track vsts issue. We update readme in separate pr

@leonardoanalista leonardoanalista merged commit cce0bfb into leonardoanalista:master Oct 30, 2017
@marceloavf
Copy link
Contributor Author

Okay, waiting for the release to test it out, thanks!

@marceloavf marceloavf deleted the feature/allow-vsts-skip-ci branch October 31, 2017 10:07
@leonardoanalista
Copy link
Owner

It’s supposed to release automatically after every commit merged into master. I don’t know why it didn’t release. I’ll have to investigate tomorrow

@marceloavf
Copy link
Contributor Author

No problem, this should help semantic-release/semantic-release#347

@marceloavf
Copy link
Contributor Author

Seems that the node 8 version have to be the build leader to publish, or use some build stages to make it work properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants