Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pr-flow.yml #326

Merged
merged 2 commits into from
May 6, 2024
Merged

Update pr-flow.yml #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f13575c
Update pr-flow.yml
leonardinius May 6, 2024
4e5d2f6
wip
leonardinius May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/pr-flow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ jobs:
go-version-file: 'go.mod'
- name: golangci-lint
uses: golangci/golangci-lint-action@v5
with:
skip-pkg-cache: true
test:
name: run tests
runs-on: ubuntu-latest
Expand Down
6 changes: 4 additions & 2 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ linters-settings:
sloglint:
no-mixed-args: true
kv-only: true
context-only: true
context: all
static-msg: true
# Enforce a single key naming convention. Values: snake, kebab, camel, pascal. Default: ""
key-naming-case: snake
Expand All @@ -37,8 +37,10 @@ linters:
- gochecknoglobals
- gochecknoinits
- goconst
- goerr113
- err113
- gomnd
- mnd
- execinquery
- ireturn
- nlreturn
- nonamedreturns
Expand Down
4 changes: 2 additions & 2 deletions app/upstream/upstream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ func newRandIntStruc() *randIntStruc {
}

func (s *randIntStruc) Intn(n int) int {
max := big.NewInt(int64(n))
val, err := rand.Int(rand.Reader, max)
maxN := big.NewInt(int64(n))
val, err := rand.Int(rand.Reader, maxN)
if err != nil {
panic(err) // out of randomness, should never happen.
}
Expand Down