nrf_modem: add dect-phy binaries #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eivindj-nordic
force-pushed
the
dect_phy_sample
branch
2 times, most recently
from
1f23507
to
c39a106
Compare
eivindj-nordic
force-pushed
the
dect_phy_sample
branch
2 times, most recently
from
4cca82c
to
818443e
Compare
eivindj-nordic
force-pushed
the
dect_phy_sample
branch
2 times, most recently
from
1bd1d8f
to
6d49271
Compare
| @@ -0,0 +1,1190 @@ | |||
| /* | |||
| * Copyright (c) 2022 Nordic Semiconductor ASA. All Rights Reserved. | |||
There was a problem hiding this comment.
Suggested change
| * Copyright (c) 2022 Nordic Semiconductor ASA. All Rights Reserved. | |
| * Copyright (c) 2024 Nordic Semiconductor ASA. All Rights Reserved. |
There was a problem hiding this comment.
This is not new, but has existed in nrf-dect repo for a time, so I don't think it is correct to have 2024 here.
lemrey
reviewed
Apr 11, 2024
nrf_modem/Kconfig
Outdated
| bool "Link LTE binary" | ||
|
|
||
| config NRF_MODEM_LINK_BINARY_DECT_PHY | ||
| bool "Link DECT binary" |
There was a problem hiding this comment.
Perhaps DECT PHY is more correct here?
There was a problem hiding this comment.
Renamed in the second commit (lte->cellular rename commit). Maybe it should be in the first.
anhmolt
approved these changes
Apr 16, 2024
|
Could we avoid adding the binaries & headers here? We only need the |
I would like to keep it to be able to build NCS (dect) samples on the integration branches without building from source. |
eivindj-nordic
force-pushed
the
dect_phy_sample
branch
3 times, most recently
from
c797117
to
d1eb49a
Compare
Prepare to add Dect NR+ PHY modem library binaries to nrfxlib. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
dect_phy_sample
branch
from
d1eb49a
to
331cc34
Compare
lemrey
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Dect NR+ PHY modem library binaries to nrfxlib.