Add '--no-fallback-messages' flag to silence fallback messages #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my environment, the tests failed because of the config file. I think it is not good idea to rely on the config file during tests so I added 'skip' to skip reading the config file.
Currently, fallback messages are always shown when the lemonade server is down.
I understand that it is quite important to tell what happens to the users.
However, I often found that the messages are bit annoying, especially when I
use lemonade as a clipboard program of neovim by manually assign `g:clipboard`.
So I added '--no-fallback-messages' flag to silence this warning like:
$ echo 'hello' | pbcopy
$ ./lemonade paste --host="127.0.0.1" --no-fallback-messages
hello
$ ./lemonade paste --host="127.0.0.1"
2018/01/24 06:05:37 dial tcp 127.0.0.1:2489: getsockopt: connection refused
2018/01/24 06:05:37 Fall back to localhost
hello
This commit fixes lemonade-command#27
|
Thank you for your pull-request. The feature is reasonable to me. |
|
Fair enough. I wait 👍 |
|
|
|
@lambdalisue @raa0121 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, fallback messages are always shown when the lemonade server is down.
I understand that it is quite important to tell what happens to the users.
However, I often found that the messages are bit annoying, especially when I
use lemonade as a clipboard program of neovim by manually assign
g:clipboard.So I added '--no-fallback-messages' flag to silence this warning like:
This commit fixes #27