Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lh5concat: allow concatenating of group-like structs #121

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

ManuelHu
Copy link
Contributor

"fixes" #119

this does not (yet) have a general fix as it only warns about a known "blacklist" of unmergeable data.

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.30%. Comparing base (782f566) to head (0104086).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
src/lgdo/cli.py 71.42% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   78.05%   78.30%   +0.25%     
==========================================
  Files          46       46              
  Lines        3368     3384      +16     
==========================================
+ Hits         2629     2650      +21     
+ Misses        739      734       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@gipert gipert added enhancement New feature or request lh5 HDF5 I/O labels Nov 21, 2024
@gipert gipert merged commit 9d1ad8f into legend-exp:main Nov 21, 2024
15 checks passed
@gipert gipert linked an issue Nov 21, 2024 that may be closed by this pull request
@ManuelHu ManuelHu deleted the lh5concat-struct branch November 21, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lh5 HDF5 I/O
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lh5concat silently drops data it can't merge
2 participants