Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug in reading nested vectors of vectors #115

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

iguinn
Copy link
Contributor

@iguinn iguinn commented Nov 5, 2024

Recent merge broke nested VoV. This is a fix for that
We should add some tests for this feature; I think including some evt tier data in the test data would help with this (legend-exp/legend-testdata#21)

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.34%. Comparing base (782f566) to head (7a6e180).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   78.05%   78.34%   +0.28%     
==========================================
  Files          46       46              
  Lines        3368     3362       -6     
==========================================
+ Hits         2629     2634       +5     
+ Misses        739      728      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert
Copy link
Member

gipert commented Nov 5, 2024

Mmmh I'm not sure I'm completely comfortable with this. I think we should try to figure out why that reference is not unique...

@iguinn
Copy link
Contributor Author

iguinn commented Nov 5, 2024

This was popping up while reading in the VoV, so there wasn't some sort of external reference causing this. Somehow another reference must be popping up in the process of reading out the evt tier.

I will add that this is likely to flare up during iterative use. In an iterator loop, it is going to be quite reasonable to view_as a table, and the reference in that view will exist when reading in the next chunk of entries.

@gipert gipert changed the title Fixed but in reading nested vectors of vectors Fixed bug in reading nested vectors of vectors Nov 9, 2024
@gipert gipert linked an issue Nov 21, 2024 that may be closed by this pull request
@iguinn
Copy link
Contributor Author

iguinn commented Nov 25, 2024

Had a look at this. The reason the reference was not unique is that I was accessing it with the iterator, and view_asing it. This is an old, known problem that doesn't have an easy solution. One thing that works is to just del the pandas/awkward view at the end of the loop block, but I think people will have trouble with that. Otherwise, the nested VoV thing was fixed by the other line that was changed.

@iguinn iguinn merged commit 94cb680 into legend-exp:main Nov 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: cannot concatenate LEGEND event files
2 participants