Fix signature for URLs that contain colons (:
)
#1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
s3browser
is generating links with the wrong signature if the file path includes a colon.This can be tested by creating a file
test.txt
and anothertext:colons.txt
in the bucket root, and running the project withS3_SIGNED_URL=true
. The link fortest.txt
works, but the one fortext:colons.txt
results in aSignatureDoesNotMatch
error.