Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signature for URLs that contain colons (:) #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matiasgarciaisaia
Copy link

s3browser is generating links with the wrong signature if the file path includes a colon.

This can be tested by creating a file test.txt and another text:colons.txt in the bucket root, and running the project with S3_SIGNED_URL=true. The link for test.txt works, but the one for text:colons.txt results in a SignatureDoesNotMatch error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant