-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch/copywriting #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump bl from 2.2.0 to 2.2.1 in /03 Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1. - [Release notes](https://github.com/rvagg/bl/releases) - [Commits](rvagg/bl@v2.2.0...v2.2.1) --- updated-dependencies: - dependency-name: bl dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Bump bl from 2.2.0 to 2.2.1 * Bump pug from 2.0.3 to 3.0.1 Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
danielepolencic
approved these changes
Jun 8, 2022
> **Pro tip:** find out about all available Service types with | ||
> ``` | ||
> kubectl explain service.spec.type | ||
> ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a limitation of our markdown engine, but the blockquote will break with the current change as the triple ticks are rendered as a full editor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Chapter 1
retrieveNotes
to be more readableChapter 2
Chapter 3
Chapter 4
Notes to Project maintainers:
In Chapter 2 onwards, we have been telling readers that the application is available from Docker as:
learnk8s/knote-js:1.0.0
orlearnk8s/knote-js:2.0.0
→ it is up to y’all if you folks want to release
1.0.1
&2.0.1
containing the dependency updates, or replace the existing version.Please check the following in Chapter 2
assets/service.svg
is the same asassets/service-with-ports.svg
→ from reading the article, it feels that it is intended to be different.kubectl explain service.spec.type
is cut off a little, so I changed that from an inline code to block code. please help to check if later it still renders as intended.Comments on Chapter 3