Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: incremental elaboration of Verso documents #78

Merged
merged 10 commits into from
Apr 26, 2024

Conversation

david-christiansen
Copy link
Collaborator

Based on leanprover/lean4#3849

The API is still a bit fiddly, so this code needs some cleanup prior to merge

@david-christiansen david-christiansen marked this pull request as ready for review April 19, 2024 06:45
@david-christiansen david-christiansen requested a review from Kha April 19, 2024 06:46
@david-christiansen
Copy link
Collaborator Author

@Kha - I think this is still using the framework in the intended manner, though I lifted out the hairy parts to a helper. I'm not totally satisfied by how the different monads interact, but couldn't immediately think of a nicer way.

Is this about how you'd imagined it being, or am I missing some low-hanging fruit for simplification?

@david-christiansen david-christiansen changed the title WIP: incremental elaboration of Verso documents feat: incremental elaboration of Verso documents Apr 19, 2024
src/verso/Verso/Doc/Elab/Incremental.lean Outdated Show resolved Hide resolved
src/verso/Verso/Doc/Elab/Incremental.lean Outdated Show resolved Hide resolved
@david-christiansen
Copy link
Collaborator Author

Note to self after call: check getAndResetMessageLog, that avoids double-reported diagnostics from incrementality

@david-christiansen
Copy link
Collaborator Author

OK, I think this is as ready as it's getting, though some items may not work until leanprover/lean4#3940. Once that's in, I'll try again, but this is already better than it was.

@david-christiansen david-christiansen merged commit 82e2332 into main Apr 26, 2024
3 checks passed
@david-christiansen david-christiansen deleted the incr-tactic branch April 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants