Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lake: v4.16.0-rc1 trace issues #6627

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Jan 13, 2025

This PR aims to fix the trace issues reported by Mathlib that are breaking lake exe cache in downstream projects.

@tydeu tydeu added the changelog-lake Lake label Jan 13, 2025
@tydeu tydeu force-pushed the lake/fix-trace-issues branch from 0985fd5 to 2e63412 Compare January 13, 2025 12:53
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 13, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 13, 2025
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 13, 2025
@kim-em
Copy link
Collaborator

kim-em commented Jan 13, 2025

This is being tested at leanprover-community/mathlib4#20711. If that works, we can merge this and backport.

@kim-em kim-em marked this pull request as ready for review January 13, 2025 14:08
@kim-em kim-em enabled auto-merge January 13, 2025 14:08
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 13, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em kim-em added this pull request to the merge queue Jan 13, 2025
Merged via the queue into leanprover:master with commit a6eea4b Jan 13, 2025
22 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 13, 2025
This PR aims to fix the trace issues reported by Mathlib that are
breaking `lake exe cache` in downstream projects.

(cherry picked from commit a6eea4b)
tydeu added a commit that referenced this pull request Jan 13, 2025
This PR aims to fix the trace issues reported by Mathlib that are
breaking `lake exe cache` in downstream projects.

(cherry picked from commit a6eea4b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport releases/v4.16.0 builds-mathlib CI has verified that Mathlib builds against this PR changelog-lake Lake toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants