Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make sure whitespace is printed before tactic configuration #6161

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: make sure whitespace is printed before tactic configuration #6161

merged 1 commit into from
Nov 21, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Nov 21, 2024

This PR ensures whitespace is printed before +opt and -opt configuration options when pretty printing, improving the experience of tactics such as simp?.

Reported on Zulip

@kmill
fix: make sure whitespace is printed before tactic configuration
6db98d6 
This PR ensures whitespace is printed before `+opt` and `-opt` configuration options when pretty printing, improving the experience of tactics such as `simp?`.

Reported [on Zulip](https://leanprover.zulipchat.com/#narrow/channel/270676-lean4/topic/Minor.20simp.3F.20annoyances/near/483736310)
@kmill kmill added the changelog-pp Pretty printing label Nov 21, 2024
@kmill kmill enabled auto-merge November 21, 2024 18:59
@kmill kmill added this pull request to the merge queue Nov 21, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 21, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase fc4305ab15d7137f6bda64a557dc2ca9c6fc460f --onto 72e952eadc6a171310f1d8e9d6e78acf98421494. (2024-11-21 19:23:15)

Merged via the queue into leanprover:master with commit aca9929 Nov 21, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog-pp Pretty printing toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmill @leanprover-community-bot