Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: BitVec.getMsbD_[ofNatLt|allOnes|not] #6149

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

tobiasgrosser
Copy link
Contributor

This PR completes the elementwise accessors for ofNatLt, allOnes, and not by adding their implementations of getMsbD.

@tobiasgrosser
Copy link
Contributor Author

changelog-library

@github-actions github-actions bot added the changelog-library Library label Nov 21, 2024
This PR completes the elementwise accessors for `ofNatLt`, `allOnes`, and
`not`, by adding their implementations of `getMsbD`.
@tobiasgrosser
Copy link
Contributor Author

@kim-em, adding changelog-library via PR comment works, but the CI must be re-triggered via a git push -f or sth similar, but the relevant CI task does not re-check automatically as the comment is added.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 21, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9cf83706e743debb47f3b1a48e1b92210c1c0720 --onto 7fbe8e3b36faabc9cfcc45e65a4b7ef042c0b068. (2024-11-21 10:10:53)

@kim-em
Copy link
Collaborator

kim-em commented Nov 21, 2024

@kim-em, adding changelog-library via PR comment works, but the CI must be re-triggered via a git push -f or sth similar, but the relevant CI task does not re-check automatically as the comment is added.

Thanks for the report, I'll check it out. Strangely, adding the label by hand does automatically trigger CI again.

@kim-em kim-em added this pull request to the merge queue Nov 21, 2024
Merged via the queue into leanprover:master with commit 7f2e7e5 Nov 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants