Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle reordered indices in structural recursion #6116

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Nov 18, 2024

This PR fixes a bug where structural recursion did not work when indices
of the recursive argument appeared as function parameters in a different
order than in the argument's type's definition.

Fixes #6015.

This PR fixes a bug where structural recursion did not work when indices
of the recursive argument appeared as function parameters in a different
order than in the argument's type's definition.

Fixes #6015.
@nomeata nomeata added will-merge-soon …unless someone speaks up changelog-language Language features, tactics, and metaprograms labels Nov 18, 2024
@nomeata nomeata added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Nov 18, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 18, 2024 10:30 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 18, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 18, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 18, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 18, 2024 11:20 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 18, 2024
@nomeata nomeata added this pull request to the merge queue Nov 18, 2024
@nomeata nomeata removed the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Nov 18, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 18, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 18, 2024

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 18, 2024
Merged via the queue into master with commit 799b2b6 Nov 18, 2024
20 checks passed
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
This PR fixes a bug where structural recursion did not work when indices
of the recursive argument appeared as function parameters in a different
order than in the argument's type's definition.

Fixes leanprover#6015.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Structural recursion: wrong motive generated
2 participants