-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: attribute delaborators #6115
Draft
digama0
wants to merge
4
commits into
leanprover:master
Choose a base branch
from
digama0:attribute_delab
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digama0
requested review from
hargoniX,
Vtec234,
mhuisi,
Kha,
leodemoura and
tydeu
as code owners
November 18, 2024 08:37
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Nov 18, 2024
Mathlib CI status (docs):
|
digama0
added
changelog-language
Language features, tactics, and metaprograms
changelog-pp
Pretty printing
and removed
changelog-language
Language features, tactics, and metaprograms
labels
Nov 18, 2024
There's now an updated |
kim-em
reviewed
Nov 19, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 19, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 19, 2024
leanprover-community-bot
added
the
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
label
Nov 19, 2024
digama0
force-pushed
the
attribute_delab
branch
from
November 19, 2024 10:22
6c00658
to
df7a7bf
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 19, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 19, 2024
digama0
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 19, 2024
Drafting pending acceptance of RFC |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
changelog-pp
Pretty printing
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables attributes to be able to specify how they would like to be shown in
#print
as additional attribute syntax, withAttributeImpl.delab
being a rough inverse toAttributeImpl.add
. As a result, this now works:Additional comments:
delab
function are such thatfun _ => pure ()
is always an okay backup plan.delab
field is not optional. I hope this can be used at least to clean up mathlib as well, but in the final version I expectdelab
to be optional and defaulted tofun _ => pure ()
to make it backward compatible.Closes #6107