Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: @[deprecated] requires a replacement identifier or message, and a since field #6112

Merged
merged 11 commits into from
Nov 26, 2024
Merged

feat: @[deprecated] requires a replacement identifier or message, and a since field #6112

merged 11 commits into from
Nov 26, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Nov 18, 2024

This PR makes stricter requirements for the @[deprecated] attribute, requiring either a replacement identifier as @[deprecated bar] or suggestion text @[deprecated "Past its use by date"], and also requires a since := "..." field.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 18, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 18, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 62ae320e1cab66b394ff96d01bb90335e325e3fd --onto a074bd9a2bd20cc470fbff4f80f2cd7b51ec0d0a. (2024-11-18 05:07:43)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 62ae320e1cab66b394ff96d01bb90335e325e3fd --onto 5a99cb326c9e9052e135cc63ed02b63371cff6d3. (2024-11-19 02:15:08)
  • 💥 Mathlib branch lean-pr-testing-6112 build failed against this PR. (2024-11-21 08:13:45) View Log
  • 💥 Mathlib branch lean-pr-testing-6112 build failed against this PR. (2024-11-23 10:12:21) View Log
  • 💥 Mathlib branch lean-pr-testing-6112 build failed against this PR. (2024-11-24 00:06:04) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 9a17919ef11c2dba824498229633b8333a0b53d9 --onto 20acc72a29a8bb4d55223651caa0553ffa82ac88. (2024-11-26 06:25:39)
  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-11-26 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-11-26 08:42:27)

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 18, 2024 06:23 Inactive
@kim-em kim-em added the awaiting-review Waiting for someone to review the PR label Nov 19, 2024
@kim-em kim-em changed the title chore: @[deprecated] requires a replacement identifier or message, and a since field feat: @[deprecated] requires a replacement identifier or message, and a since field Nov 19, 2024
@kim-em kim-em added the changelog-language Language features, tactics, and metaprograms label Nov 19, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 19, 2024 05:44 Inactive
@kim-em kim-em force-pushed the stricter_deprecations branch from 52cad82 to ac59a1e Compare November 21, 2024 07:08
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 21, 2024 07:30 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 21, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6112
fcc096f
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 21, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6112
9c25cf1
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Nov 21, 2024
@Kha Kha removed the awaiting-review Waiting for someone to review the PR label Nov 22, 2024
@kim-em
Copy link
Collaborator Author

kim-em commented Nov 23, 2024

This will require some Mathlib cleanup before we can merge. Discussion at zulip.

This was referenced Nov 23, 2024
Merged
Closed
@kim-em kim-em added this pull request to the merge queue Nov 25, 2024
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Nov 25, 2024
@kim-em
chore: ensure there is a replacement identifier or text suggestion fo…
3fa5f45 
…r all deprecations (#19426)

This is for compatibility with the stricter requirements of leanprover/lean4#6112.

Anyone is welcome to replace the "No deprecation message was provided." messages in other PRs! :-)
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 25, 2024
@kim-em kim-em enabled auto-merge November 26, 2024 06:01
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 26, 2024 06:14 Inactive
@kim-em kim-em added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@kim-em kim-em requested review from digama0 and tydeu as code owners November 26, 2024 07:23
@kim-em kim-em enabled auto-merge November 26, 2024 07:23
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 26, 2024 07:44 Inactive
@kim-em kim-em added this pull request to the merge queue Nov 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 26, 2024
@kim-em kim-em enabled auto-merge November 26, 2024 08:26
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc November 26, 2024 08:44 Inactive
@kim-em kim-em added this pull request to the merge queue Nov 26, 2024
Merged via the queue into master with commit f70b7e5 Nov 26, 2024
15 checks passed
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
@kim-em @JovanGerb
feat: @[deprecated] requires a replacement identifier or message, a…
e92a1e8 
…nd a `since` field (leanprover#6112)

This PR makes stricter requirements for the `@[deprecated]` attribute,
requiring either a replacement identifier as `@[deprecated bar]` or
suggestion text `@[deprecated "Past its use by date"]`, and also
requires a `since := "..."` field.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha Kha Kha approved these changes

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@tydeu tydeu Awaiting requested review from tydeu tydeu is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kim-em @leanprover-community-bot @Kha