-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: BitVec.signExtend.{toNat, toInt} #6038
Conversation
Mathlib CI status (docs):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor remarks, I got two additional ones:
- Could you rebase your branch on leanprover master? The test task IO flipper should be gone there.
- Did you check that your theorem statements are in simp normal form?
28e29f4
to
1baa298
Compare
This PR adds toNat and toInt theorems for BitVec.signExtend. Co-authored-by: Siddharth Bhat <[email protected]> Co-authored-by: Harun Khan <[email protected]>
The PR now just seems to consist of a change to code that is fine according to the style guide? What is the motivation here? |
My bad, I didn't see that the theorems got merged into main in the meantime. Closing this :). |
This PR adds toNat and toInt theorems for BitVec.signExtend.