Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't duplicate goals in rw #4383

Closed
wants to merge 3 commits into from
Closed

fix: don't duplicate goals in rw #4383

wants to merge 3 commits into from

Conversation

JovanGerb
Copy link
Contributor

Closes #4381

@JovanGerb JovanGerb mentioned this pull request Jun 6, 2024
Closed
3 tasks
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 6, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jun 6, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4383
e643360
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jun 6, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4383
04ddfd8
@leodemoura
Copy link
Member

@JovanGerb Thanks for creating the issue and submitting the PR. However, we will fix the issue using #4385.

@leodemoura leodemoura closed this Jun 6, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases labels Jun 6, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rw duplicates goals for metavariables appearing in the rewritten expression
3 participants
@JovanGerb @leodemoura @leanprover-community-mathlib4-bot