refactor: Canonicalizer: run getFunInfo on expression, not key
#3875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Canonicalizer creates a “key” expression eliding certain information (implicit parameters, levels), and `getFunInfo` can be confused by these terms (in particular, wrong number of level parameters). By running `getFunInfo` on the original expression we avoid this, and can just put `[]` as the level list in the key.
nomeata
changed the title
getFunInfo on expressiongetFunInfo on expression, not key
github-actions
bot
added
the
toolchain-available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Canonicalizer creates a “key” expression eliding certain information
(implicit parameters, levels), and
getFunInfocan beconfused by these terms (in particular, wrong number of level
parameters).
By running
getFunInfoon the original expression we avoid this, andcan just put
[]as the level list in the key.