chore: when setting up Mathlib CI, make sure nightly-with-mathlib branch has been fetched #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nch has been fetched
github-actions
bot
added
the
toolchain-available
nomeata
added a commit
that referenced
this pull request
Apr 15, 2024
this refines upon #3834, which didn’t quite work, and was producing ``` From https://github.com/leanprover/lean4 * branch nightly-with-mathlib -> FETCH_HEAD * [new branch] nightly-with-mathlib -> origin/nightly-with-mathlib fatal: ambiguous argument 'nightly-with-mathlib': unknown revision or path not in the working tree. ``` Probably `git -C lean4.git fetch origin nightly-with-mathlib:nightly-with-mathlib` would have worked, or using `rev-parse origin/nightly-with-mathlib`. We now get the commit hash via `git ls-remote`, which I’d wager is a bit more robust, as it is independent of the local state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported on zulip.