Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2024 borrowing benchmarking #3817

Closed
wants to merge 57 commits into from
Closed

2024 borrowing benchmarking #3817

wants to merge 57 commits into from

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Apr 1, 2024

Read this section before submitting

  • Ensure your PR follows the External Contribution Guidelines.
  • Please make sure the PR has excellent documentation and tests. If we label it missing documentation or missing tests then it needs fixing!
  • Include the link to your RFC or bug issue in the description.
  • If the issue does not already have approval from a developer, submit the PR as draft.
  • The PR title/description will become the commit message. Keep it up-to-date as the PR evolves.
  • If you rebase your PR onto nightly-with-mathlib then CI will test Mathlib against your PR.
  • You can manage the awaiting-review, awaiting-author, and WIP labels yourself, by writing a comment containing one of these labels on its own line.
  • Remove this section, up to and including the --- before submitting.

Closes #0000 (RFC or bug issue number fixed by this PR, if any)

bollu and others added 30 commits March 27, 2024 17:09
@bollu
feat: disable reset reuse
e4adbbc
@bollu
feat: bring back research_isReuseAcrossConstructorsEnabled
fe104e0
@bollu
feat: add coarse grained profiling
d7a02ca
@bollu
feat: trim CI so we can get fast turnaround
3355be8
@bollu
feat: add profiling env vars
eef38fe
@bollu
feat: add current folder
3b59386
@bollu
export lean options via CMAKE options
f6728f2
@bollu
add logs and scripts of first run
27cdd6d
@bollu
feat: turn of ccache
1568813
@bollu
add run at 22:25
aaa7a96
@bollu
plot more stuff
0a3ffe5
@bollu
plot this run, make changes for next run
07d233a
@bollu
feat: add scripts for next run
0415652
@bollu
feat: add new run details
47a307f
@bollu
feat: small perg regression on stage3: ../1-runs/run-2023-03-28---23-…
15bdb2f 
…51/plot-stage3.ipynb
@bollu
feat: allow benching with and without LEAN_RUNTIME_STATS
cf5bdfc
@bollu
feat: add macbook run [wip, need to update plotting scripts
8a9f9e9
@bollu
no real perf delta
020d56f
@bollu
ïncorrect half-run on mac
adb747b
@bollu
delete ResetReuse, add two versions into filesystem
caf0b07
@bollu
add script for incorrect benching setup
bb748b6
@bollu
fix: bring back baseline ResetReuse algo, turns out removing 'getPref…
0a97ce4 
…ix' breaks stage2 build!
@bollu
feat: log C file size
c639117
@bollu
feat: run stage3 build for noreuse and reuse, compare timing and file…
3c8ec92 
… size
@bollu
feat: add the CSV data as well
75538d5
@bollu
feat: add latest run from yday
c016a25
@anfelor @bollu
New drop and reuse specialization pass
ddeaf66
@anfelor @bollu
feat: Enable new pass
7cc0f17
@anfelor @bollu
fix: Check whether a token is a scalar in interpreter
5415c50
@bollu
feat: rescript to build 2 separate repos
0d954cd
bollu and others added 26 commits March 31, 2024 10:03
@bollu
feat: plot stage3
70d41b1
@bollu
add morning run
51068e5
@bollu
annoying, seems like the rebase broke ctest?
2e4112b
@bollu
feat: run ctest on stage3
87f3895
@bollu
add next run with stage3 check
4925291
@bollu
add 10:43 run data
aeeb3e9
@bollu
feat: add temci
133c0fa
@bollu
keep backup of CSV files right after stage3 runs
bcf387a 
This prevents us from clobbering it with irrelevant data from temci.
@bollu
rerun ctest, we seem to be flaky
a3cd6a9
@bollu
add data for compiler files only
28f1fad
@bollu
new run, this time saving CSV intermediate
13a64ef
@bollu
add latest run with clean ctest
1ed512b
@bollu
add scripting to recompile stdlib
91cf24c
@bollu
add stdlib recompile stage3 info
d09f785
@bollu
add noreuse recompile times as well
dd4b27c
@bollu
add temci report
78bf8fe
@anfelor
feat: faster lean_is_null check
c5aec5e
@anfelor
feat: simplify join points in drop specialization
0660a8b
@anfelor
chore: eliminate dead code in ExpandResetReuse
0a06060
@anfelor
feat: add comments and remove quadratic behaviour in ExpandResetReuse
79ae165
@anfelor
Revert "feat: add comments and remove quadratic behaviour in ExpandRe…
57dd7d5 
…setReuse"

This reverts commit 79ae165.
@bollu
feat: add version of compiler build where we use different stage0, bu…
8697b1b 
…t same stage1 source code
@bollu
add scripts for compiler run where we can use different stage0, same …
fa1110c 
…stage1
@bollu
chore: check in older files
ba267fd
@bollu
chore: check in older files
af2c717
@bollu
feat: add default profile path so that CI does not complain
6ca22fc
@bollu bollu requested review from leodemoura, Kha and kim-em as code owners April 1, 2024 13:34
@bollu bollu closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@Kha Kha Awaiting requested review from Kha

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bollu @anfelor