Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue when matching Int literals #3504

Merged
merged 1 commit into from
Feb 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/Lean/Meta/Match/Match.lean
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,21 @@ private def isNatValueTransition (p : Problem) : MetaM Bool := do
unless (← hasNatValPattern p) do return false
return hasCtorOrInaccessible p

/--
Predicate for testing whether we need to expand `Int` value patterns into constructors.
There are two cases:
- We have constructor or inaccessible patterns. Example:
```
| 0, ...
| Int.toVal p, ...
...
```
- We don't have the `else`-case (i.e., variable pattern). This can happen
when the non-value cases are unreachable.
-/
private def isIntValueTransition (p : Problem) : MetaM Bool := do
unless (← hasIntValPattern p) do return false
return hasCtorOrInaccessible p
return hasCtorOrInaccessible p || !hasVarPattern p

private def processSkipInaccessible (p : Problem) : Problem := Id.run do
let x :: xs := p.vars | unreachable!
Expand Down
12 changes: 12 additions & 0 deletions tests/lean/run/match_int_lit_issue.lean
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
theorem Int.eq_zero_of_sign_eq_zero' : ∀ {a : Int}, sign a = 0 → a = 0
| 0, _ => rfl

def foo (a : Int) : Bool :=
match a with
| Int.ofNat 0 => true
| Int.ofNat 1 => true
| _ => false

example : ∀ {a : Int}, foo a = true → a = 0 ∨ a = 1
| 0, _ => Or.inl rfl
| 1, _ => Or.inr rfl
Loading