Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: generalize msb_eq_decide to also handle the zero width case #3480

Merged
merged 2 commits into from
Mar 1, 2024
Merged

feat: generalize msb_eq_decide to also handle the zero width case #3480

merged 2 commits into from
Mar 1, 2024

Conversation

bollu
Copy link
Contributor

@bollu bollu commented Feb 23, 2024

Note that this is a strict generalization of the previous statemens of getLsb_last and msb_eq_decide that worked for bitwidths >= 1.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Std/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4d941476431cec18a00f723e67342c883388721a --onto 5a32473f6695b44643ef81522e892c7d7b4be8d2. (2024-02-23 16:13:31)

@bollu bollu changed the title feat: generalize msb_eq_decide to also handle the zero width case. feat: generalize msb_eq_decide to also handle the zero width case Feb 24, 2024
@bollu
Copy link
Contributor Author

bollu commented Feb 24, 2024

awaiting-review

@github-actions github-actions bot added the awaiting-review Waiting for someone to review the PR label Feb 24, 2024
@bollu bollu mentioned this pull request Feb 24, 2024
Closed
@kim-em kim-em added awaiting-author Waiting for PR author to address issues and removed awaiting-review Waiting for someone to review the PR labels Feb 25, 2024
@bollu
Copy link
Contributor Author

bollu commented Feb 25, 2024

awaiting-review

@github-actions github-actions bot added awaiting-review Waiting for someone to review the PR and removed awaiting-author Waiting for PR author to address issues labels Feb 25, 2024
@kim-em kim-em added this pull request to the merge queue Feb 29, 2024
Merged via the queue into leanprover:master with commit ed02262 Mar 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em kim-em left review comments

Assignees
No one assigned
Labels
awaiting-review Waiting for someone to review the PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bollu @leanprover-community-mathlib4-bot @kim-em